> > Yes, i am a u-blox employee and i've been asked to integrate LARA-L6 in > > the linux kernel and update the current code for LARA-R6 00B (updating > > the PID from 0x90fa to 0x908b). > > Thanks. Was it it also a colleague of yours that submitted the initial > PID then? Correct, the initial PID has been submitted by another u-blox employee. > > The first prototype of LARA-R6 00B had 0x90fa PID but, just before the > > product finalization, it has been decided to adopt a new USB composition > > and consequently a change of PID was necessary. > > The 0x90fa PID has been used only for some internal prototypes, hence > > no u-blox products with that PID have been shipped to customers. > > As pointed out in the discussion, the 0x90fa PID is used by other module > > vendors which sell Qualcomm based modems, hence i proposed to remove the > > association between u-blox (thedefine UBLOX_PRODUCT_R6XX) and 0x90fa, > > moving it directly in the option_ids array. > > Thanks, this is the kind of details we've been asking for. Please put > some of this in the commit in some form so that it is obvious from just > reading the commit message that the patch is correct and safe to apply. > > Make sure to mention that this Qualcomm PID is used by other products > and that's why you're leaving it in. Perhaps a Link tag with a > reference to Lars message pointing this out is in place. For example: Ok thanks for the suggestions. I will add all the details to the v6 1/3 patch. > > Thanks for the suggestions. In order to simplify the submission process, > > i propose to split the submission for the LARA-L6 patches and the update > > for LARA-R6 00B. > > Do you think could it be feasible? > > I don't think that's necessary now that you've provided some more > details. Just respin the series and address the review comments given > so far (either by rejecting a suggestion and explaining why, or by > incorporating it in your next submission). > > It seems you only need to tweak some of the commit messages in a v6. I will submit a v6 version of the patch with the provided suggestions. I have just one doubt, in patch v6, should i edit also the previous sent changelog by describing changes to each indiviual sub-patch? Thank you for the patience. Davide
