On Wed, Nov 09, 2022 at 05:17:11PM +0100, Davide Tronchin wrote: > The LARA-R6 module old PID (defined as: UBLOX_PRODUCT_R6XX > 0x90fa) has been removed since is no longer used by the > current u-blox LARA-R6 product. However, PID 0x90fa has been > kept to maintain the support to other products that use the > same VID/PID. First, please wrap your commit messages at 72 column or so (not 60). We've asked you repeatedly whether you for u-blox or not, but you keep ignoring this question. Knowing this would allow us to better evaluate the reasoning and motivation behind this this change. The above commit message still does not explain why you want to remove it and whether it would be safe to do so. Why was added in the first place? What u-blox products used the old PID? By just removing the define this is less of an issue, but you should not make the life of reviewers harder by ignoring request to properly motivate your changes and explain why they are safe to apply. > Signed-off-by: Davide Tronchin <davide.tronchin.94@xxxxxxxxx> > --- > > V4 -> V5: kept PID 0x90fa to maintain the support for other products > which use VID:PID 0x05c6:0x90fa. Remove interface 4 from blacklist > for LARA-L6 default mode since it is not needed. You can either put a shared changelog for the whole series in a cover letter, or you describe changes to each individual patch. But mixing the two styles as you do in this entry is just confusing. > V3 -> V4: as requested, the patch has been split to 3 sub-patches. > Fix comment format. > > V2 -> V3: added this section to tracking changes with previous versions. > Added some explanations about the RSVD(4) in the description session. > Added reservation to port 4 of VID:PID 0x05C6:0x908B to meet other > companies QMI net interface implementation. > > V1 -> V2: define UBLOX_PRODUCT_LARA_R6 0x908b has been deleted together > with the previosly provided definition of USB_DEVICE since the PID > is used by another vendor. > The LARA-L6 patch part is the same of the previosly provided one. Johan
