Re: [PATCH v2] char: xillybus: Prevent use-after-free due to race condition

To: Hyunwoo Kim <imv4bel@xxxxxxxxx>
Subject: Re: [PATCH v2] char: xillybus: Prevent use-after-free due to race condition
From: Eli Billauer <eli.billauer@xxxxxxxxx>
Date: Sun, 13 Nov 2022 13:36:08 +0200
Cc: gregkh@xxxxxxxxxxxxxxxxxxx, arnd@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, stern@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20221113091415.GA8314@ubuntu>
References: <20221030094209.65916-1-eli.billauer@gmail.com> <20221113080558.GA5854@ubuntu> <2a8f59ac-9d49-ffa3-b035-809f2fac38ec@gmail.com> <20221113084740.GA6458@ubuntu> <c9a03f08-8117-cd24-b4e3-9e097e3069f2@gmail.com> <20221113091415.GA8314@ubuntu>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0

On 13/11/2022 11:14, Hyunwoo Kim wrote:


It seems that you only need to move the location of unit_mutex
in xillybus_find_inode().


Agreed. I'll prepare a follow-up patch to fix this issue as well.

Thanks a lot for drawing my attention to this.

  Eli

References:
- [PATCH v2] char: xillybus: Prevent use-after-free due to race condition
  - From: Eli Billauer
- Re: [PATCH v2] char: xillybus: Prevent use-after-free due to race condition
  - From: Hyunwoo Kim
- Re: [PATCH v2] char: xillybus: Prevent use-after-free due to race condition
  - From: Eli Billauer
- Re: [PATCH v2] char: xillybus: Prevent use-after-free due to race condition
  - From: Hyunwoo Kim
- Re: [PATCH v2] char: xillybus: Prevent use-after-free due to race condition
  - From: Eli Billauer
- Re: [PATCH v2] char: xillybus: Prevent use-after-free due to race condition
  - From: Hyunwoo Kim