On Tue, Nov 08, 2022 at 11:50:07AM +0100, Linus Walleij wrote:
> On Tue, Nov 8, 2022 at 4:16 AM Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
>
> > Commit 84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()") changed
> > qe_pin_request() to request and hold GPIO corresponding to a given pin.
> > Unfortunately this does not work, as fhci-hcd requests these GPIOs
> > first, befor calling qe_pin_request() (see
> > drivers/usb/host/fhci-hcd.c::of_fhci_probe()).
> > To fix it change qe_pin_request() to request GPIOs non-exclusively, and
> > free them once the code determines GPIO controller and offset for each
> > GPIO/pin.
> >
> > Also reaching deep into gpiolib implementation is not the best idea. We
> > should either export gpio_chip_hwgpio() or keep converting to the global
> > gpio numbers space until we fix the driver to implement proper pin
> > control.
> >
> > Fixes: 84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()")
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> Wow! Thanks for fixing this!
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> I just sent that patch into the SoC patch tracker (soc@xxxxxxxxxx)
> with a not to apply it directly, I suggest you do the same (or ask me
> to sign it off and send it).
It depends on the patch in my tree, which is in your tree as well.
I guess you need to take or wait for v6.2-rc1.
--
With Best Regards,
Andy Shevchenko
