On Sat, Nov 05, 2022 at 08:46:25PM +1100, Albert Zhou wrote: > Hi Greg, Hi! Some meta-comments, please don't top-post and try line-wrapping your emails at 72 columns to make it easier to respond properly. See the mailing list archives for examples. > I realised several things. Firstly, when I initially contacted you, it was simply based on looking up who maintained drivers/net/usb in the MAINTAINERS file, however when running scripts/get_maintainer.pl, I realise that there are many other people who maintain drivers/net/usb/r8152.c. Should I include them in future submissions? Or should I just stick to you for now? Yes, include everyone that get_maintainer.pl tells you to, that's what it is there for. > Secondly, running scripts/checkpatch.pl on Realtek's code gives many warnings and errors. E.g. the code is written to be compatible > for old versions of the kernel, whereas checkpatch.pl insists that each kernel version should have dedicated code for itself. And that's not needed for in-kernel drivers at all, which is why it is complaining. You should remove all of that compatibility cruft as it just clutters up the code and is not needed for obvious reasons. > I am hesitant to edit the original code more than I already have, but if necessary, I can make another patch when I resubmit to iron out all the trivial style issues. However I may need some guidance, e.g. on the use of the volatile keyword; since I am not the original developer, it will be difficult for met to judge whether its usage is critical for the code. Look at how it is being used and see if it is required. For a USB driver, volitile should never be used as it makes no sense at all, right? > Thirdly, if I do remove all of the macros for backwards compatibility, (# if LINUX_VERSION_CODE >= KERNEL_VERSION(a,b,c)), it will be difficult for distros like Ubuntu to incorporate the updated module into their older kernels. How can the version-two module also be included in the other stable/longerm kernels? We do kernel development for the latest release only. If distros want to backport things, that's up to them to do on their own. For stable/long term kernels, see the stable documentation for what is a valid acceptable change (hint, bug fixes and quirks and device ids only, not new features or new drivers.) So all of that code for old kernels needs to be removed. Do that and you will end up with a much smaller and actually maintable codebase, so that's a good thing to do. hope this helps, greg k-h
