________________________________________ From: Greg KH [greg@xxxxxxxxx] Sent: Wednesday, October 14, 2009 6:47 AM To: Oliver Neukum Cc: Elina Pasheva; linux-usb@xxxxxxxxxxxxxxx Subject: Re: [patch]fix sierra's close in suspended case On Wed, Oct 14, 2009 at 03:38:14PM +0200, Oliver Neukum wrote: >> Am Mittwoch, 14. Oktober 2009 15:24:20 schrieb Greg KH: >> > On Wed, Oct 14, 2009 at 10:44:31AM +0200, Oliver Neukum wrote: >> > > sierra_close() must resume the device before it notifies it of a closure >> > > >> > > Signed-off-by: Oliver Neukum <oliver@xxxxxxxxxx> >> > > >> > > Hi, >> > > >> > > this is needed only in mainline. >> > > >> > > Elina, strictly speaking with this patch your earlier patch is correct, >> > > but it still makes no sense to go through setting up the timers and >> > > all that, so please reverse the order of calls in your patch. >> > >> > So take this patch instead of the 1/2 patch from Elina? >> >> No, Elina fixed a real bug. This patch is needed in addition. >> But I would like Elina to redo patch #1 of her series to be cleaner. >Ok, I'll wait for Elina's refresh. Elina, can you include Oliver's patch >in your next patch series that you send out? Hi, Thanks for the review and additions, Oliver and Greg. I will redo the patch, include Oliver's patch as well and re-submit possibly tomorrow. Thanks, Elina >thanks, >greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
