Re: [PATCH 1/2] dt-bindings: usb: usb-nop-xceiv: add wakeup-source property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24/10/2022 01:17, Li Jun wrote:
> usb phy may be part of wakeup source, so add wakeup source property

s/usb/USB/

"part of wakeup source" is actually not descriptive. What do you want to
say here?

> to keep its resource(e.g power domain) active to make usb remote

space before (
s/e.g/e.g./
s/usb/USB/

> wakeup work.
> 
> Signed-off-by: Li Jun <jun.li@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml
> index 2824c17285ee..7b71e32d1df0 100644
> --- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.yaml
> @@ -39,6 +39,11 @@ properties:
>        the VBus line.
>      $ref: /schemas/types.yaml#/definitions/phandle
>  
> +  wakeup-source:
> +    $ref: /schemas/types.yaml#/definitions/flag

This shouldn't be needed, as it is a standard property.

> +    description:
> +      Specify if it's USB remote wakeup capable.

Now you have to explain in the bindings what is "USB remote wakeup".

Best regards,
Krzysztof




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux