Am Mittwoch, 14. Oktober 2009 00:22:42 schrieb Elina Pasheva:
> --- a/drivers/usb/serial/sierra.c 2009-10-09 16:41:31.000000000 -0700
> +++ b/drivers/usb/serial/sierra.c 2009-10-09 16:48:46.000000000 -0700
> @@ -825,6 +825,8 @@ static int sierra_open(struct tty_struct
>
> err = sierra_submit_rx_urbs(port, GFP_KERNEL);
> if (err) {
> + /* restore balance for autopm */
> + usb_autopm_put_interface(serial->interface);
> /* get rid of everything as in close */
> sierra_close(port);
> return err;
You must put the call after the call to sierra_close() or the device may
be autosuspended before sierra_close() calls sierra_send_setup().
In fact sierra_close() is also buggy in that regard. I'll make a patch
to fix sierra_close().
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
