Hi, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Wednesday, October 19, 2022 6:52 AM > To: Xu Yang <xu.yang_2@xxxxxxx>; Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>; > gregkh@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; > s.hauer@xxxxxxxxxxxxxx > Cc: kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx>; Peng Fan > <peng.fan@xxxxxxx> > Subject: Re: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: convert > to DT schema > > On 16/10/2022 23:17, Xu Yang wrote: > > Hi Krzysztof, > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >> Sent: Saturday, October 15, 2022 10:53 PM > >> To: Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>; > >> gregkh@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > >> krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; > >> s.hauer@xxxxxxxxxxxxxx; Xu Yang <xu.yang_2@xxxxxxx> > >> Cc: kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx > >> <linux-imx@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; > >> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > >> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx>; Peng > >> Fan <peng.fan@xxxxxxx> > >> Subject: [EXT] Re: [PATCH V2 1/6] dt-bindings: usb: usbmisc-imx: > >> convert to DT schema > >> > >> Caution: EXT Email > >> > >> On 14/10/2022 05:51, Peng Fan (OSS) wrote: > >>> From: Peng Fan <peng.fan@xxxxxxx> > >>> > >>> Convert usbmisc-imx to DT schema format. > >>> > >>> Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > >>> --- > >>> .../devicetree/bindings/usb/fsl,usbmisc.yaml | 52 > +++++++++++++++++++ > >>> .../devicetree/bindings/usb/usbmisc-imx.txt | 18 ------- > >>> 2 files changed, 52 insertions(+), 18 deletions(-) create mode > >>> 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > >>> delete mode 100644 > >>> Documentation/devicetree/bindings/usb/usbmisc-imx.txt > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > >> b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > >>> new file mode 100644 > >>> index 000000000000..c83ffb6729b5 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > >>> @@ -0,0 +1,52 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > >>> +--- > >>> +$id: > >> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > >> > cetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmi&data=05%7C01%7Cjun.li%40 > >> > nxp.com%7C15ee8a29acf04f95ff4108dab15b5b88%7C686ea1d3bc2b4c6fa92cd99c > >> > 5c301635%7C0%7C0%7C638017303177794862%7CUnknown%7CTWFpbGZsb3d8eyJWIjo > >> > iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C > >> %7C%7C&sdata=tovO%2F6fnxAMSUu9hTFv1Kgarmo%2BwxKCxS%2FeJAbt3e0k%3 > D > >> &reserved=0 > >> > sc.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82b830d9f47018 > >> ff408daaebcf83d%7C686ea1d3bc2b4c6 > >> > fa92cd99c5c301635%7C0%7C0%7C638014423898086337%7CUnknown%7CTWFpbGZsb3 > >> d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi > >> > V2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gNwM > >> bGsiuMS1zgvbgATYAY70gv2nIhX%2F > >> 16IxiSYBf3s%3D&reserved=0 > >>> +$schema: > >>> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde > >>> > +vicetree.org%2Fmeta-&data=05%7C01%7Cjun.li%40nxp.com%7C15ee8a29 > >>> > +acf04f95ff4108dab15b5b88%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > >>> > +%7C638017303177794862%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiL > >>> > +CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&s > >>> > +data=NxKdgHlJ9q%2F82XtXwWxHf5UFJR3v08L83jomQxg3Blo%3D&reserved= > >>> +0 > >> > schemas%2Fcore.yaml%23&data=05%7C01%7Cxu.yang_2%40nxp.com%7C24e82 > >> b830d9f47018ff408daaebcf83d%7C68 > >> > 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638014423898242035%7CUnknown > >> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjA > >> > wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a > >> mp;sdata=jJUP5aKNkfkAefhNQL9almV > >> Gqzn8cTNyjcRlZMOZwRk%3D&reserved=0 > >>> + > >>> +title: Freescale i.MX non-core registers > >> > >> You sent v2 before we finished this topic. Is it correct? Even if TXT > >> had such title, let's don't keep the wrong name. > >> > >> If it is non-core registers, why it is in USB? Why it is an usb-misc device? > > > > The chipidea's doc has a more clear explanation about core and > > non-core registers as follow: > > > > "There are two kinds of registers in the USB module: USB core > > registers and USB non-core registers. USB core registers are used to > > control USB core functions, and more independent of USB features. Each > > USB controller core has its own core registers. USB non-core registers > > are additional to USB core registers, and more dependent on USB > > features. i.MX series products vary in non-core registers." > > > > So we have named it like this. > > "Freescale i.MX non-core registers" implies this hardware is about i.MX > registers. i.MX like for all SoCs. > > What you wrote now, about USB registers - quite different. > > However if you describe here registers, not some device, usually it's place > is not USB... > > And actually all devices are bunch of registers, right? So everything should > be called registers? > > Name is poor choice, so please find more appropriate one matching real purpose > of this block. How about "Freescale i.MX wrapper module for Chipidea USB2 controller" Thanks Li Jun > > > Best regards, > Krzysztof
