On Wed, 2022-10-12 at 12:43 +0100, Jon Hunter wrote: > On 12/10/2022 12:18, Greg KH wrote: > > On Wed, Oct 12, 2022 at 06:25:11PM +0800, Jim Lin wrote: > > > +static inline struct tegra_xusb *hcd_to_tegra_xusb(struct > > > usb_hcd *hcd) > > > +{ > > > + return (struct tegra_xusb *) dev_get_drvdata(hcd- > > > >self.controller); > > > > No need for the cast (and if there was, no need for the extra > > space). > > May be best to drop this inline function completely and call > dev_get_drvdata() directly. I only see it used in one place. > > Jon > Thanks, will do. --nvpublic