On Wed, Oct 12, 2022 at 11:08:06AM -0500, Rob Herring wrote: > On Tue, Oct 11, 2022 at 10:29:24AM +0200, Sascha Hauer wrote: > > Following the example of samsung,picophy-dc-vol-level-adjust more > > phy tuning properties are added for configuring the remaining bitfields > > in the USBNC_n_PHY_CFG1 register. > > All these properties really doesn't scale. These properties should go > in the phy node as they are properties or the phy. There's no rule that > you can only read properties from the driver's device node. I understand and agree. On i.MX8M we currently use the usb-nop-xceiv. I guess it's not an option to just add these properties there, so we'll need a phy node with a new compatible like fsl,imx8mm-usbphy. The driver would basically just register a usb-nop-xceiv and the node would be a container for the new property. Does this sound sane? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
