Re: [PATCH 4/6] usb: whci-hcd: always do an update after processing a halted qTD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 12, 2009 at 06:19:35PM +0100, David Vrabel wrote:
> Sergei Shtylyov wrote:
> > David Vrabel wrote:
> >> +			/* A halted qTD always triggers an update
> >> +			   because the qset was either removed or
> >> +			   reactivated. */
> >> +			update |= WHC_UPDATE_UPDATED;
> >>  			goto done;
> >>  		}
> > 
> >    Doucmentation/CodingStyle: [on long comments]
> 
> 1. It's not a long comment; it's a single sentence.
> 
> 2. Nitpicking trivial style issues on the 2nd time a patch has been
> posted is not helpful.

I agree.  CodingStyle is a _GUIDELINE_, not something that always needs
to be intrepreted literally for every single patch for trivial things
like this.

I see nothing wrong with this patch as-is.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux