On 7.10.2022 19.42, Limonciello, Mario wrote:
[Public]
-----Original Message-----
From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Sent: Friday, October 7, 2022 04:55
To: Limonciello, Mario <Mario.Limonciello@xxxxxxx>
Cc: Mathias Nyman <mathias.nyman@xxxxxxxxx>; Mehta, Sanju
<Sanju.Mehta@xxxxxxx>; Mathias Nyman
<mathias.nyman@xxxxxxxxxxxxxxx>; Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; linux-
kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v2 1/2] xhci-pci: Set runtime PM as default policy on all
xHC 1.2 or later devices
On Thu, Oct 06, 2022 at 04:15:28PM -0500, Mario Limonciello wrote:
- if (pdev->vendor == PCI_VENDOR_ID_AMD &&
- (pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_1 ||
- pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_2 ||
- pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_3 ||
- pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_4 ||
- pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_5 ||
- pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_6 ||
- pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_7 ||
- pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_8))
Can you add a comment here explaining why this is OK? I think it is
easier that way to find out why this is here in the future instead of
going through the git blame history.
Sure, no problem.
I'll hold off sending a v3 though until you and Mathias can double check
everything in patch 2/2 is OK to take out and agree with that secondary logic
change.
+ if (xhci->hci_version >= 0x102)
Shouldn't this be ">= 0x120"
Thanks
Mathias
