Re: [PATCH] pxa27x_udc: avoid compiler warnings and misbehavior on buggy hardware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 12, 2009 at 6:13 PM, Enrico Scholz
<enrico.scholz@xxxxxxxxxxxxxxxxx> wrote:
> Eric Miao <eric.y.miao@xxxxxxxxx> writes:
>
>>> irq_handle_data() might do out-of-bound access to ep[] array when
>>> hardware reports wrong interrupt.  Although such a situation should
>>> not happen, the compiler complains about this access.
>>
>> In the outer loop, there is a condition (i < 16) and (i < 24) in the second,
>> I doubt the endpoint number will ever exceed. What exactly the compiler
>> is complaining about?
>
>>> +                       ep = &udc->pxa_ep[i];
>
> This field is declared as pxa_ep[NR_PXA_ENDPOINTS] and NR_PXA_ENDPOINTS is
> smaller than 24 (defined as 15 in current sources).  Compiler complains
> about a possible out-of-bound access.
>

Robert,

I seem to remember PXA27x has 24 EPs, and why NR_PXA_ENDPOINTS
is 16 here?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux