Hello Krzysztof, Thanks for the review comments. Please find my inline comments with tag [Piyush]. Regards, Piyush Mehta > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Tuesday, September 13, 2022 2:52 PM > To: Mehta, Piyush <piyush.mehta@xxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx; > robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; balbi@xxxxxxxxxx > Cc: linux-usb@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>; Paladugu, > Siva Durga Prasad <siva.durga.prasad.paladugu@xxxxxxx>; Manish Narani > <manish.narani@xxxxxxxxxx> > Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include > hibernation interrupt > > On 12/09/2022 10:57, Piyush Mehta wrote: > > From: Manish Narani <manish.narani@xxxxxxxxxx> > > > > The hibernation feature enabled for Xilinx ZynqMP SoC in DWC3 IP. > > Added the below interrupt-names in the binding schema for the same. > > > > dwc_usb3: dwc3 core interrupt-names > > otg: otg interrupt-names > > hiber: hibernation interrupt-names > > This does not make sense in commit msg. Don't duplicate patch in commit > msg. [Piyush]: Will rephrase the commit message and send V2. > Where is the user (DTS) and implementation of this change? If this is specific > to Xilinx, why you do not have device specific compatible? [Piyush]: We have dedicated irq line for hibernation feature, "hiber" irq line triggers hibernation interrupt. DWC3 core supports the hibernation feature, we have a dedicated code which is yet to be upstreamed. As the hibernation feature provided by dwc3-core, so this will be supported by other SOC/vendors. > > > > > Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx> > > Signed-off-by: Piyush Mehta <piyush.mehta@xxxxxxx> > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > index 1779d08ba1c0..618fa7bd32be 100644 > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > @@ -53,6 +53,8 @@ properties: > > - const: dwc_usb3 > > - items: > > enum: [host, peripheral, otg] > > + - items: > > + enum: [dwc_usb3, otg, hiber] > > > > Best regards, > Krzysztof
