On Fri, Sep 09, 2022 at 09:22:25PM +0800, zhongling0719@xxxxxxx wrote: > Sorry , I tested it work well on Win7, not good on Win10. I would guess that Windows 7 doesn't use UAS but Windows 10 does. It's surprising that these devices can be sold nowadays if they don't work with Windows 10 -- who would buy them? > I don't have Mac OSX system. We always work on linux environment. > Need I resend the version V5 for patch 3 cancel "acked by" ? Greg, do you have an opinion? I don't feel very strongly about this. Alan Stern > Thanks! > > zhongling0719@xxxxxxx > > From: Alan Stern > Date: 2022-09-09 20:15 > To: Hongling Zeng > CC: gregkh; linux-usb; usb-storage; zhongling0719 > Subject: Re: [PATCH v4 3/3] uas: ignore UAS for Thinkplus chips > On Fri, Sep 09, 2022 at 06:48:50PM +0800, Hongling Zeng wrote: > > The UAS mode of Thinkplus is reported to fail to work on > > several platforms with the following error message: > > > > [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled > > endpoint or incorrect stream ring > > [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 > > 1b000000 05038000 > > > > Falling back to USB mass storage can solve this problem, so ignore UAS > > function of this chip. > > > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > > I never sent you an Acked-by: for this patch. In fact, I asked you > questions about it which you haven't yet answered. > > Specifically: How do Windows and Mac OSX work with this drive? > > Alan Stern > > > Signed-off-by: Hongling Zeng <zenghongling@xxxxxxxxxx> > > --- > > Change for v1 > > - Change the email real name and the code worng place. > > > > Change for v2 > > -Change spelling error. > > > > Change for v3 > > -Add acked-by > > > > Change for v4 > > -Fix version error > > --- > > drivers/usb/storage/unusual_uas.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h > > index 8a18d58..156e89c 100644 > > --- a/drivers/usb/storage/unusual_uas.h > > +++ b/drivers/usb/storage/unusual_uas.h > > @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, > > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > > US_FL_NO_ATA_1X), > > > > +/* Reported-by: Hongling Zeng <zenghongling@xxxxxxxxxx> */ > > +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, > > + "Thinkplus", > > + "External HDD", > > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, > > + US_FL_IGNORE_UAS), > > + > > /* Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx> */ > > UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, > > "VIA", > > -- > > 2.1.0 > >
