On Tue, Sep 06, 2022 at 06:11:28PM +0800, Szuying Chen wrote: > From: Szuying Chen <Chloe_Chen@xxxxxxxxxxxxxx> > > Hi, > > > > > +static int asmedia_switch_nvm_version(struct tb_nvm *nvm) { > > + struct tb_switch *sw = tb_to_switch(nvm->dev); > > + u32 val; > > + int ret; > > + > > + ret = tb_switch_nvm_read(sw, ASMEDIA_NVM_VERSION, &val, sizeof(val)); > > + if (ret) > > + return ret; > > + > > + nvm->major = (val << 16) & 0xff0000; > > + nvm->minor |= val & 0x00ff00; > > nvm->major Heh, that one was clearly a copy paste error ;-) I will fix it up when applying. Thanks for checking.