On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit, so let's switch to the generic > fwnode property API. > > While at it switch the rest of the calls to read properties in it, switch > bd9576_wdt_probe() to the generic device property API as well. ... > struct device *dev = &pdev->dev; struct device *parent = dev->parent; can make your code slightly neater. ... > + count = device_property_count_u32(dev->parent, "rohm,hw-timeout-ms"); > + if (count < 0 && count != -EINVAL) > + return count; > + > + if (count > 0) { > + if (count > ARRAY_SIZE(hw_margin)) > + return -EINVAL; Why double check? You may move it out of the (count > 0). ... > - if (ret == 1) > - hw_margin_max = hw_margin[0]; > + ret = device_property_read_u32_array(dev->parent, > + "rohm,hw-timeout-ms", > + hw_margin, count); > + if (ret < 0) > + return ret; So, only this needs the count > 0 check since below already has it implicitly. > - if (ret == 2) { > - hw_margin_max = hw_margin[1]; > - hw_margin_min = hw_margin[0]; > + if (count == 1) > + hw_margin_max = hw_margin[0]; > + > + if (count == 2) { > + hw_margin_max = hw_margin[1]; > + hw_margin_min = hw_margin[0]; > + } > } -- With Best Regards, Andy Shevchenko