On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > I would like to limit (or maybe even remove) use of > [devm_]gpiod_get_from_of_node in drivers so that gpiolib can be cleaned > a bit, so let's switch to the generic device property API. It may even > help with handling secondary fwnodes when gpiolib is taught to handle > gpios described by swnodes. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index 8e323e93be91..929f9363e94b 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -2202,10 +2202,11 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie) > * and in this case fall back to using AFI per port register > * to toggle PERST# SFIO line. > */ > - rp->reset_gpio = devm_gpiod_get_from_of_node(dev, port, > - "reset-gpios", 0, > - GPIOD_OUT_LOW, > - label); > + rp->reset_gpio = devm_fwnode_gpiod_get(dev, > + of_fwnode_handle(port), > + "reset", > + GPIOD_OUT_LOW, > + label); Why in pci-aardvark.c for PERST# reset-gpio you have used devm_gpiod_get_optional() and here in pci-tegra.c you have used devm_fwnode_gpiod_get()? I think that PERST# logic is same in both drivers. > if (IS_ERR(rp->reset_gpio)) { > if (PTR_ERR(rp->reset_gpio) == -ENOENT) { > rp->reset_gpio = NULL; > > -- > b4 0.10.0-dev-fc921