Re: [PATCH 001/001] USB: serial: sierra driver memory reduction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 08, 2009 at 05:21:05PM -0700, Elina Pasheva wrote:
> Subject: [PATCH 001/001] USB: serial: sierra driver memory reduction
> From: Elina Pasheva <epasheva@xxxxxxxxxxxxxxxxxx>
> This patch deals with reducing the memory footprint for sierra driver.
> This optimization is aimed for embedded software customers. 
> The interfaces with low memory requirements are assigned less memory 
> (in number of urbs) thus reducing the overall memory footprint of the driver.

You're kidding right?

Is a struct urb that big?  What is the memory footprints you are dealing
with here that this makes a difference?

What about performance issues with smaller number of urbs, this change
will make some device now go slower, which isn't a nice thing :(

> Applying this patch to the current sierra.c driver in the kernel will make
> the source identical with the version available from the sierra wireless 
> knowledgebase website. That is why the version number is being changed 
> to 1.7.12 as part of this patch.

I see a bugfix snuck in here that you should send separately, as it has
nothing to do with the memory size changes.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux