Thanks for the feedback ! Brain fade moment of not including commit message. Not exporting symbols anymore and I have squashed the patch as well into "[PATCH v2 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback" which I just sent out. On Tue, Aug 30, 2022 at 6:00 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Fri, Aug 26, 2022 at 01:40:00AM -0700, Badhri Jagan Sridharan wrote: > > Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx> > > As Heikki pointed out, I can not accept changes with no changelog text > at all, you know this. > > Please write a good changelog text that explains why you are doing this > so we can properly review it. As it is, we have no idea what is going > on here at all. > > thanks, > > greg k-h