Re: [PATCH v2] usb: Improves USB2.0 write performance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 29, 2022 at 04:58:57PM +0800, Hu Xiaoying wrote:
> From: Hu Xiaoying <huxiaoying@xxxxxxxxx>
> 
> USB external storage device(0x0b05:1932), use gnome-disk-utility tools
> to test usb write  < 30MB/s.
> Then, igoned to load module of uas for this device.
--------^^^^^^

"igoned" is not a word in English.

> ===============================================

Why did you put this line here?

> Write speed: Improves form 27MB/s to 40MB/s+
------------------------^^^^
---------------------------------------^^^^^^^
"from", not "form".
"> 40MB/s", not "40MB/s+".

> 
> Signed-off-by: Hu Xiaoying <huxiaoying@xxxxxxxxx>
> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h
> b/drivers/usb/storage/unusual_uas.h
> index 4051c8cd0cd8..abaf4ea8138b 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -157,3 +157,10 @@ UNUSUAL_DEV(0x4971, 0x8024, 0x0000, 0x9999,
>                 "External HDD",
>                 USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>                 US_FL_ALWAYS_SYNC),
> +
> +/* Reported-by: Tom Hu <huxiaoying@xxxxxxxxx> */
> +UNUSUAL_DEV(0x0b05, 0x1932, 0x0000, 0x9999,
> +               "ASUS",
> +               "External HDD",
> +               USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +               US_FL_IGNORE_UAS),

Entries should be sorted by vendor ID and product ID.  This entry is 
added in the wrong place (0x0b05 comes before 0x4971, not after).

Alan Stern



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux