On Fri, Aug 26, 2022 at 09:17:32AM +0000, cgel.zte@xxxxxxxxx wrote: > From: xupanda <xu.panda@xxxxxxxxxx> > > Return the value regmap_update_bits() directly instead of > storing it in another redundant variable. > > Reported-by: Zeal Robot <zeal@xxxxxxxxxx> > Signed-off-by: xupanda <xu.panda@xxxxxxxxxx> This needs to be a real (full) name. > > --- > change for v2 > - remove those irrelevant sentences > --- > > drivers/usb/typec/tcpm/tcpci.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c > index b2bfcebe218f..29047da826a9 100644 > --- a/drivers/usb/typec/tcpm/tcpci.c > +++ b/drivers/usb/typec/tcpm/tcpci.c > @@ -328,11 +328,9 @@ static int tcpci_set_vconn(struct tcpc_dev *tcpc, bool enable) > static int tcpci_enable_auto_vbus_discharge(struct tcpc_dev *dev, bool enable) > { > struct tcpci *tcpci = tcpc_to_tcpci(dev); > - int ret; > > - ret = regmap_update_bits(tcpci->regmap, TCPC_POWER_CTRL, TCPC_POWER_CTRL_AUTO_DISCHARGE, > + return regmap_update_bits(tcpci->regmap, TCPC_POWER_CTRL, TCPC_POWER_CTRL_AUTO_DISCHARGE, > enable ? TCPC_POWER_CTRL_AUTO_DISCHARGE : 0); Continuation line alignment still needs to be adjusted. Both were aready mentioned in feedback to v1 of the patch. Guenter