Re: Commit 'r8152: fix a WOL issue' makes Ethernet port on Lenovo Thunderbolt 3 dock go crazy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25.08.22 18:13, Jakub Kicinski wrote:
> On Thu, 25 Aug 2022 09:26:21 +0200 Thorsten Leemhuis wrote:
>> On 24.08.22 13:16, Thorsten Leemhuis wrote:
>>> Hi, this is your Linux kernel regression tracker.
>>>
>>> Quick note before the boilerplate: there is another report about issues
>>> caused by cdf0b86b250fd3 also involving a dock, but apparently it's
>>> ignored so far:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=216333  
>>
>> TWIMC, apparently it's the same problem.
>>
>> Fun fact: Hayes discussed this in privately with the bug reporter
>> according to this comment:
>> https://bugzilla.kernel.org/show_bug.cgi?id=216333#c3
>>
>> Well, that's not how things normally should be handled, but whatever, he
>> in the end recently submitted a patch to fix it that is already merged
>> to net.git:
>>
>> https://lore.kernel.org/lkml/20220818080620.14538-394-nic_swsd@xxxxxxxxxxx/
> 
> Yup, it will be part of 6.0-rc3. 

Great. BTW, a small note for Hayes and reviewers: The commit
b75d61201444 ("r8152: fix the RX FIFO settings when suspending") links
to the report with a "BugLink" tag. You want to use plain "Link:" tags
instead, as explained in the documentation. Also: a "BugLink" tag not
that long ago made Linus write:

```
please stop making up random tags that make no sense.

Just use "Link:"
```

Quote from:
https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@xxxxxxxxxxxxxx/

Ciao, Thorsten



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux