Hey, This is a follow-up to "[RFC v1] USB: core: add USBDEVFS_REVOKE ioctl" from April. The end-goal is being able to cut-off access to USB devices for applications/programs that open raw USB devices using, in most cases, libusb. I've implemented this using BPF, so we don't need to add new ioctls. The presence or absence of that feature can be evaluated at runtime, and can be used to implement revoke support on session switching, in logind for example: https://github.com/hadess/usb-revoke-userspace/ I have some notes and questions on the API as it is exposed. - I didn't see a point in having multiple kernel functions as entry points as I was going to use a single BPF program as an entry point, which can check the arguments. Can I rely on the BPF program checking those arguments, or should I re-check them again in the kernel implementation? - Are my UID checks correct if I expect revoking to be called outside namespaces, on the effective UID of the user. Is there a way to assert that? - Is there a good "errno" error for ENOSUCHUSER for using in the usb_revoke() loop if we couldn't find any USB device matching the requested user? Cheers Bastien Nocera (2): USB: core: add a way to revoke access to open USB devices usb: Implement usb_revoke() BPF function drivers/usb/core/devio.c | 105 ++++++++++++++++++++++++++++++++++++--- drivers/usb/core/usb.c | 51 +++++++++++++++++++ drivers/usb/core/usb.h | 8 +++ 3 files changed, 158 insertions(+), 6 deletions(-) -- 2.36.1
