Re: [usb-storage] Toshiba G450 kernel patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 7 Oct 2009, Peter Magdina wrote:

> Finally I did this test on kernel without my patch to proof
> that it fully works also from userspace:
> - plugged Toshiba G450 modem into USB port
> - usb-storage module was loaded and detected it as a CD-ROM
> - I ran eject /dev/sr1  command which ejected the device from /dev/sr1
> - devices switched over to modem - I saw it in syslog 
> - as I did not have usbserial and option modules loaded, I had to load them
>   to have /sys/bus/usb-serial/drivers/option1/new_id available
> - then I did: echo '0930 0d45' >new_id
> - option modules discovered 3 serial ports and created 3 serial devices in /dev
> - than I also tried pppd connection to the provider and browsed a bit
> It works perfect.
> 
> However, one conclusion is here.
> If you want to put it only into userspace (without even patching option
> driver to support this device), then udev scripts must handle if option
> driver is already loaded or not and eventually load it and write new VID/PID
> to "new_id".
> If this whole handling is ok according to you, then I don't mind.
> But as far as there exists other VIDs/PIDs in option driver, it would be
> nice to put also this one there and than the only thing which will have to
> be done by udev script is to eject the device.

I agree, the IDs should be added to the option driver.  That is a 
small, self-contained, unobjectionable patch.  When it is added, the 
user won't need to do anything other than run the eject or modeswitch 
programs.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux