Does a larger value of the delay_use parameter remove the need for the fake inquiry? Matt On Tue, Oct 06, 2009 at 11:57:00PM +0200, Peter Magdina wrote: > Hi Matt, > > > What's the deal with the "special" inquiry command you send as part of > > initialization? The code suggests that you're trying to detect something, > > but all you look for is a response to, as far as I can tell, a normal > > INQUIRY command.... > > I just played with the patch again to fine tune patch file to comply > requirements of checkpatch.pl script and I also tested if I really > can somehow drop that fake inquiry. I've found out that it is not > possible. That device does not respond correctly during first bulk > transfer and this inquiry detects it and as the init routine exits > with 0 error code even after wrong result of inquiry routine, > usb-store module does not send error message into syslog. > Second and subsequent transfers work so second inquiry returns > with 0 code and the switchmode routine is run afterwards. > And switch mode should run well otherwise init will return with -EIO > error code. > > I have cleaned up a bit the patch file. Find it attached to this email. > I've already updated it on the page: > http://www.magdina.org/projects/toshiba-g450-kernel-patch > > Peter -- Matthew Dharm Home: mdharm-usb@xxxxxxxxxxxxxxxxxx Maintainer, Linux USB Mass Storage Driver It's not that hard. No matter what the problem is, tell the customer to reinstall Windows. -- Nurse User Friendly, 3/22/1998
Attachment:
pgpFaKM5cT2Jp.pgp
Description: PGP signature
