Hi Greg, On Fri, Feb 18, 2022 at 05:59:48PM +0800, 3090101217@xxxxxxxxxx wrote: > From: Jing Leng <jleng@xxxxxxxxxxxxx> > > On page 362 of the USB3.2 specification ( > https://usb.org/sites/default/files/usb_32_20210125.zip), > The 'SuperSpeed Endpoint Companion Descriptor' shall only be returned > by Enhanced SuperSpeed devices that are operating at Gen X speed. > Each endpoint described in an interface is followed by a 'SuperSpeed > Endpoint Companion Descriptor'. > > If users use SuperSpeed UDC, host can't recognize the device if endpoint > doesn't have 'SuperSpeed Endpoint Companion Descriptor' followed. > > Currently in the uac2 driver code: > 1. ss_epout_desc_comp follows ss_epout_desc; > 2. ss_epin_fback_desc_comp follows ss_epin_fback_desc; > 3. ss_epin_desc_comp follows ss_epin_desc; > 4. Only ss_ep_int_desc endpoint doesn't have 'SuperSpeed Endpoint > Companion Descriptor' followed, so we should add it. > > Fixes: eaf6cbe09920 ("usb: gadget: f_uac2: add volume and mute support") > Signed-off-by: Jing Leng <jleng@xxxxxxxxxxxxx> > --- > ChangeLog v3->v4: > - Add "Fixes:" tag in the changelog area > ChangeLog v2->v3: > - Remove static variables which are explicitly initialized to 0 > - Remove redundant modification "case USB_SPEED_SUPER_PLUS:" > ChangeLog v1->v2: > - Update more detailed description of the PATCH I don't see this patch in any of your trees, so I'm assuming it must not have made it into your inbox. If that's the case I would like to resubmit on Jing's behalf as it does fix a legitimate issue with enabling the UAC2 gadget in SuperSpeed. Jack
