tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 8affe37c525d800a2628c4ecfaed13b77dc5634a commit: 8bc063641cebf9d555e41d135db2b5035b521768 [27/33] usb: misc: Add onboard_usb_hub driver config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20220710/202207101421.kHbwWznT-lkp@xxxxxxxxx/config) compiler: ia64-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=8bc063641cebf9d555e41d135db2b5035b521768 git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git git fetch --no-tags usb usb-next git checkout 8bc063641cebf9d555e41d135db2b5035b521768 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/usb/ sound/soc/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/usb/core/../misc/onboard_usb_hub_pdevs.c:65:6: warning: no previous prototype for 'onboard_hub_create_pdevs' [-Wmissing-prototypes] 65 | void onboard_hub_create_pdevs(struct usb_device *parent_hub, struct list_head *pdev_list) | ^~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/usb/core/../misc/onboard_usb_hub_pdevs.c:132:6: warning: no previous prototype for 'onboard_hub_destroy_pdevs' [-Wmissing-prototypes] 132 | void onboard_hub_destroy_pdevs(struct list_head *pdev_list) | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/onboard_hub_create_pdevs +65 drivers/usb/core/../misc/onboard_usb_hub_pdevs.c 30 31 /** 32 * onboard_hub_create_pdevs -- create platform devices for onboard USB hubs 33 * @parent_hub : parent hub to scan for connected onboard hubs 34 * @pdev_list : list of onboard hub platform devices owned by the parent hub 35 * 36 * Creates a platform device for each supported onboard hub that is connected to 37 * the given parent hub. The platform device is in charge of initializing the 38 * hub (enable regulators, take the hub out of reset, ...) and can optionally 39 * control whether the hub remains powered during system suspend or not. 40 * 41 * To keep track of the platform devices they are added to a list that is owned 42 * by the parent hub. 43 * 44 * Some background about the logic in this function, which can be a bit hard 45 * to follow: 46 * 47 * Root hubs don't have dedicated device tree nodes, but use the node of their 48 * HCD. The primary and secondary HCD are usually represented by a single DT 49 * node. That means the root hubs of the primary and secondary HCD share the 50 * same device tree node (the HCD node). As a result this function can be called 51 * twice with the same DT node for root hubs. We only want to create a single 52 * platform device for each physical onboard hub, hence for root hubs the loop 53 * is only executed for the root hub of the primary HCD. Since the function 54 * scans through all child nodes it still creates pdevs for onboard hubs 55 * connected to the root hub of the secondary HCD if needed. 56 * 57 * Further there must be only one platform device for onboard hubs with a peer 58 * hub (the hub is a single physical device). To achieve this two measures are 59 * taken: pdevs for onboard hubs with a peer are only created when the function 60 * is called on behalf of the parent hub that is connected to the primary HCD 61 * (directly or through other hubs). For onboard hubs connected to root hubs 62 * the function processes the nodes of both peers. A platform device is only 63 * created if the peer hub doesn't have one already. 64 */ > 65 void onboard_hub_create_pdevs(struct usb_device *parent_hub, struct list_head *pdev_list) 66 { 67 int i; 68 struct usb_hcd *hcd = bus_to_hcd(parent_hub->bus); 69 struct device_node *np, *npc; 70 struct platform_device *pdev; 71 struct pdev_list_entry *pdle; 72 73 if (!parent_hub->dev.of_node) 74 return; 75 76 if (!parent_hub->parent && !usb_hcd_is_primary_hcd(hcd)) 77 return; 78 79 for (i = 1; i <= parent_hub->maxchild; i++) { 80 np = usb_of_get_device_node(parent_hub, i); 81 if (!np) 82 continue; 83 84 if (!of_is_onboard_usb_hub(np)) 85 goto node_put; 86 87 npc = of_parse_phandle(np, "peer-hub", 0); 88 if (npc) { 89 if (!usb_hcd_is_primary_hcd(hcd)) { 90 of_node_put(npc); 91 goto node_put; 92 } 93 94 pdev = of_find_device_by_node(npc); 95 of_node_put(npc); 96 97 if (pdev) { 98 put_device(&pdev->dev); 99 goto node_put; 100 } 101 } 102 103 pdev = of_platform_device_create(np, NULL, &parent_hub->dev); 104 if (!pdev) { 105 dev_err(&parent_hub->dev, 106 "failed to create platform device for onboard hub '%pOF'\n", np); 107 goto node_put; 108 } 109 110 pdle = kzalloc(sizeof(*pdle), GFP_KERNEL); 111 if (!pdle) { 112 of_platform_device_destroy(&pdev->dev, NULL); 113 goto node_put; 114 } 115 116 pdle->pdev = pdev; 117 list_add(&pdle->node, pdev_list); 118 119 node_put: 120 of_node_put(np); 121 } 122 } 123 EXPORT_SYMBOL_GPL(onboard_hub_create_pdevs); 124 125 /** 126 * onboard_hub_destroy_pdevs -- free resources of onboard hub platform devices 127 * @pdev_list : list of onboard hub platform devices 128 * 129 * Destroys the platform devices in the given list and frees the memory associated 130 * with the list entry. 131 */ > 132 void onboard_hub_destroy_pdevs(struct list_head *pdev_list) -- 0-DAY CI Kernel Test Service https://01.org/lkp
