Hi Greg, On Jul 08 14:38, Greg Kroah-Hartman wrote: > On Thu, Jul 07, 2022 at 10:20:08PM +0000, Prashant Malani wrote: > > Introduce a retimer device class and associated functions that register > > and use retimer "switch" devices. These operate in a manner similar to > > the "mode-switch" and help configure retimers that exist between the > > Type-C connector and host controller(s). > > > > Type C ports can be linked to retimers using firmware node device > > references (again, in a manner similar to "mode-switch"). > > > > Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx> > > As you are adding things to sysfs, do you need to add any > Documentation/ABI/ entries as well? I can't see any new sysfs files > being created here, but explicitly saying so in the changelog here would > be good. There are no new sysfs files being created (there is the new retimer class directory, but there are no class-specific files being created there). I will send out a v4 which calls this out in the changelog. Best regards, -Prashant