Hi Prashant, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [cannot apply to chrome-platform/for-next linus/master balbi-usb/testing/next peter-chen-usb/for-usb-next v5.19-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Prashant-Malani/platform-chrome-Type-C-switch-driver-and-Type-C-framework-updates/20220707-012614 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220707/202207071256.63ElDHIG-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/60e03c1b36c0e3533e481b44152faab38448be5b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Prashant-Malani/platform-chrome-Type-C-switch-driver-and-Type-C-framework-updates/20220707-012614 git checkout 60e03c1b36c0e3533e481b44152faab38448be5b # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/chrome/ kernel/bpf/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/platform/chrome/cros_typec_switch.c:81:6: warning: no previous prototype for 'cros_typec_check_event' [-Wmissing-prototypes] 81 | bool cros_typec_check_event(struct cros_typec_switch_data *sdata, int port_num, u32 mask) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/platform/chrome/cros_typec_switch.c:159:6: warning: no previous prototype for 'cros_typec_unregister_switches' [-Wmissing-prototypes] 159 | void cros_typec_unregister_switches(struct cros_typec_switch_data *sdata) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/platform/chrome/cros_typec_switch.c:170:5: warning: no previous prototype for 'cros_typec_register_retimer' [-Wmissing-prototypes] 170 | int cros_typec_register_retimer(struct cros_typec_port *port, struct fwnode_handle *fwnode) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/cros_typec_check_event +81 drivers/platform/chrome/cros_typec_switch.c 80 > 81 bool cros_typec_check_event(struct cros_typec_switch_data *sdata, int port_num, u32 mask) 82 { 83 struct ec_response_typec_status resp; 84 struct ec_params_typec_status req = { 85 .port = port_num, 86 }; 87 int ret; 88 89 ret = cros_ec_command(sdata->ec, 0, EC_CMD_TYPEC_STATUS, &req, sizeof(req), 90 &resp, sizeof(resp)); 91 if (ret < 0) { 92 dev_warn(sdata->dev, "EC_CMD_TYPEC_STATUS failed for port: %d\n", port_num); 93 return false; 94 } 95 96 if (resp.events & mask) 97 return true; 98 99 return false; 100 } 101 -- 0-DAY CI Kernel Test Service https://01.org/lkp
