Hi Prashant, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [cannot apply to chrome-platform/for-next linus/master balbi-usb/testing/next peter-chen-usb/for-usb-next v5.19-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Prashant-Malani/platform-chrome-Type-C-switch-driver-and-Type-C-framework-updates/20220707-012614 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220707/202207070816.tREVcI4a-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/6d9c4808fd780ebdf18235d615764c504b95a03d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Prashant-Malani/platform-chrome-Type-C-switch-driver-and-Type-C-framework-updates/20220707-012614 git checkout 6d9c4808fd780ebdf18235d615764c504b95a03d # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/chrome/ kernel/bpf/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/platform/chrome/cros_typec_switch.c:37:6: warning: no previous prototype for 'cros_typec_unregister_switches' [-Wmissing-prototypes] 37 | void cros_typec_unregister_switches(struct cros_typec_switch_data *sdata) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/platform/chrome/cros_typec_switch.c:48:5: warning: no previous prototype for 'cros_typec_register_retimer' [-Wmissing-prototypes] 48 | int cros_typec_register_retimer(struct cros_typec_port *port, struct fwnode_handle *fwnode) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/cros_typec_unregister_switches +37 drivers/platform/chrome/cros_typec_switch.c 36 > 37 void cros_typec_unregister_switches(struct cros_typec_switch_data *sdata) 38 { 39 int i; 40 41 for (i = 0; i < EC_USB_PD_MAX_PORTS; i++) { 42 if (!sdata->ports[i]) 43 continue; 44 typec_retimer_unregister(sdata->ports[i]->retimer); 45 } 46 } 47 > 48 int cros_typec_register_retimer(struct cros_typec_port *port, struct fwnode_handle *fwnode) 49 { 50 struct typec_retimer_desc retimer_desc = { 51 .fwnode = fwnode, 52 .drvdata = port, 53 .name = fwnode_get_name(fwnode), 54 .set = cros_typec_retimer_set, 55 }; 56 57 port->retimer = typec_retimer_register(port->sdata->dev, &retimer_desc); 58 if (IS_ERR(port->retimer)) 59 return PTR_ERR(port->retimer); 60 61 return 0; 62 } 63 -- 0-DAY CI Kernel Test Service https://01.org/lkp
