Hi Steven, Thank you for the patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on linus/master v5.19-rc4 next-20220701] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/USB-gadget-udc-tracing-Do-not-open-code-__string-with-__dynamic_array/20220703-080329 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: riscv-buildonly-randconfig-r001-20220703 (https://download.01.org/0day-ci/archive/20220703/202207030931.QMgcEvNT-lkp@xxxxxxxxx/config) compiler: riscv64-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/63b33d8f7a24820f05bd2b8330b19c3d78e0c36f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Steven-Rostedt/USB-gadget-udc-tracing-Do-not-open-code-__string-with-__dynamic_array/20220703-080329 git checkout 63b33d8f7a24820f05bd2b8330b19c3d78e0c36f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/trace/define_trace.h:102, from drivers/usb/gadget/udc/trace.h:289, from drivers/usb/gadget/udc/trace.c:10: >> drivers/usb/gadget/udc/./trace.h:217:41: error: expected expression before ';' token 217 | __string(name, ep->name); | ^ include/trace/trace_events.h:244:9: note: in definition of macro 'DECLARE_EVENT_CLASS' 244 | tstruct \ | ^~~~~~~ drivers/usb/gadget/udc/./trace.h:216:9: note: in expansion of macro 'TP_STRUCT__entry' 216 | TP_STRUCT__entry( | ^~~~~~~~~~~~~~~~ vim +217 drivers/usb/gadget/udc/./trace.h 212 213 DECLARE_EVENT_CLASS(udc_log_req, 214 TP_PROTO(struct usb_ep *ep, struct usb_request *req, int ret), 215 TP_ARGS(ep, req, ret), 216 TP_STRUCT__entry( > 217 __string(name, ep->name); 218 __field(unsigned, length) 219 __field(unsigned, actual) 220 __field(unsigned, num_sgs) 221 __field(unsigned, num_mapped_sgs) 222 __field(unsigned, stream_id) 223 __field(unsigned, no_interrupt) 224 __field(unsigned, zero) 225 __field(unsigned, short_not_ok) 226 __field(int, status) 227 __field(int, ret) 228 __field(struct usb_request *, req) 229 ), 230 TP_fast_assign( 231 __assign_str(name, ep->name); 232 __entry->length = req->length; 233 __entry->actual = req->actual; 234 __entry->num_sgs = req->num_sgs; 235 __entry->num_mapped_sgs = req->num_mapped_sgs; 236 __entry->stream_id = req->stream_id; 237 __entry->no_interrupt = req->no_interrupt; 238 __entry->zero = req->zero; 239 __entry->short_not_ok = req->short_not_ok; 240 __entry->status = req->status; 241 __entry->ret = ret; 242 __entry->req = req; 243 ), 244 TP_printk("%s: req %p length %d/%d sgs %d/%d stream %d %s%s%s status %d --> %d", 245 __get_str(name),__entry->req, __entry->actual, __entry->length, 246 __entry->num_mapped_sgs, __entry->num_sgs, __entry->stream_id, 247 __entry->zero ? "Z" : "z", 248 __entry->short_not_ok ? "S" : "s", 249 __entry->no_interrupt ? "i" : "I", 250 __entry->status, __entry->ret 251 ) 252 ); 253 -- 0-DAY CI Kernel Test Service https://01.org/lkp
