Re: [PATCH 2/2] net/cdc_ncm: Add ntb_max_rx,ntb_max_tx cdc_ncm module parameters

[Lukasz Spintzyk <lukasz.spintzyk@xxxxxxxxxxxxx>]

On 14/06/2022 12:24, Lukasz Spintzyk wrote:
> On 13/06/2022 16:54, Oliver Neukum wrote:
> > CAUTION: Email originated externally, do not click links or open 
> > attachments unless you recognize the sender and know the content is safe.
> >
> >
> > On 13.06.22 10:02, Łukasz Spintzyk wrote:
> > > This change allows to optionally adjust maximum RX and TX NTB size
> > > to better match specific device capabilities, leading to
> > > higher achievable Ethernet bandwidth.
> > Hi,
> >
> > this is awkward a patch. If some devices need bigger buffers, the
> > driver should grow its buffers for them without administrative
> > intervention.
> >
> >          Regards
> >                  Oliver
>
> This is true,
> Some of DisplayLink USB ethernet devices require values of TX and RX NTB 
> size higher then 32kb and this is more then defined 
> CDC_NCM_NTB_MAX_SIZE_TX/RX
> I wanted to be careful and not increase limit of NTB size for all 
> devices. But it would also by ok to me if we could increase 
> CDC_NCM_NTB_MAX_SIZE_TX/RX to 64kb.
>
> Regards
> Lukasz Spintzyk

Hi guys,

Is there anything I could do to proceed with that patchset?

It is improving the experience for users of millions of 
DisplayLink-based docking stations that are in the wild.
That tweaks of NTB TX/RX results in approximately 4-5x available 
bandwidth improvement in extreme cases.

I think this is worth to have it upstream.

regards
Lukasz Spintzyk