On Fri, Jun 10, 2022 at 12:45:25AM -0700, Yihao Han wrote: > clk_disable() already checks the clk ptr using IS_ERR_OR_NULL(clk) It does? Are you sure? It will check for NULL, that's it. > so there is no need to check it again before calling it. This will break on some platforms, please always test your patches before sending them out. thanks, greg k-h