On Sat, May 21, 2022 at 11:08:08PM +0900, Robert Eckelmann wrote: > > This patch adds support for Agilent E5805A (rebranded ION Edgeport/4) to > io_ti. > > Signed-off-by: Robert Eckelmann <longnoserob@xxxxxxxxx> > --- > output of lsusb -v (with Serial-Number of the device anonymized): [...] > Changes in v2: > - removed documentation change > - improvements to spaceing in io_usbvend.h > - rephrasing comment in io_usbvend.h Thanks for the v2. Now applied with minor tweaks to the commit message, keeping the double newline separator after the new define, and adding the missing spaces after the USB_DEVICE macros. https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=908e698f2149c3d6a67d9ae15c75545a3f392559 > diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c > index a7b3c15957ba..ff0d05f45fce 100644 > --- a/drivers/usb/serial/io_ti.c > +++ b/drivers/usb/serial/io_ti.c > @@ -166,6 +166,7 @@ static const struct usb_device_id edgeport_2port_id_table[] = { > { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_8S) }, > { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416) }, > { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416B) }, > + { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_E5805A)}, > { } > }; > > @@ -204,6 +205,7 @@ static const struct usb_device_id id_table_combined[] = { > { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_8S) }, > { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416) }, > { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416B) }, > + { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_E5805A)}, > { } > }; > > diff --git a/drivers/usb/serial/io_usbvend.h b/drivers/usb/serial/io_usbvend.h > index 52cbc353051f..879ef755898f 100644 > --- a/drivers/usb/serial/io_usbvend.h > +++ b/drivers/usb/serial/io_usbvend.h > @@ -213,6 +213,7 @@ > // Definitions for other product IDs > #define ION_DEVICE_ID_MT4X56USB 0x1403 // OEM device > > +#define ION_DEVICE_ID_E5805A 0x1A01 // OEM device (rebranded Edgeport/4) > > #define GENERATION_ID_FROM_USB_PRODUCT_ID(ProductId) \ > ((__u16) ((ProductId >> 8) & (ION_GENERATION_MASK))) Johan