On 07/06/2022 21:00, Prashant Malani wrote:
> Analogix 7625 can be used in systems to switch USB Type-C DisplayPort
> alternate mode lane traffic between 2 Type-C ports.
>
> Update the binding to accommodate this usage by introducing a switch
> property.
>
> Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
> ---
> .../display/bridge/analogix,anx7625.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..7e1f655ddfcc 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -105,6 +105,26 @@ properties:
> - port@0
> - port@1
>
> + switches:
> + type: object
> + description: Set of switches controlling DisplayPort traffic on
> + outgoing RX/TX lanes to Type C ports.
> +
> + properties:
> + switch:
You allow only one switch with such schema, so no need for "switches"...
> + $ref: /schemas/usb/typec-switch.yaml#
> + maxItems: 2
Are you sure this works? what are you limiting here with maxItems? I
think you wanted patternProperties...
> +
> + properties:
> + reg:
> + maxItems: 1
> +
> + required:
> + - reg
> +
> + required:
> + - switch@0
This does not match the property.
You also need unevaluatedProperties:false
> +
> required:
> - compatible
> - reg
> @@ -167,5 +187,41 @@ examples:
> };
> };
> };
> + switches {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + switch@0 {
> + compatible = "typec-switch";
> + reg = <0>;
> + mode-switch;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + anx_typec0: endpoint {
> + remote-endpoint = <&typec_port0>;
Messed up indentation. Your previous patch should also switch to 4-space
as recommended by schema coding style.
> + };
> + };
> + };
> + };
> + switch@1 {
> + compatible = "typec-switch";
> + reg = <1>;
> + mode-switch;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + anx_typec1: endpoint {
> + remote-endpoint = <&typec_port1>;
Ditto.
> + };
> + };
> + };
> + };
> + };
> };
> };
Best regards,
Krzysztof
