On 07.06.22 15:58, Mathias Nyman wrote: Hi, > In shutdown (S5), with xHCI as host, this can be solved fairly easily > by turning off roothub port power in the .shutdown path. That would suck for the people who charge their phone from their computer. > This is discussed in xhci spec 4.19.4 for driver unload: > "Before the xHC driver is unloaded, the driver should clear the > Port Power (PP) flag of all Root Hub ports to place them into > the Disabled state and reduce port power consumption." Yes, you could say that the standard calls for this. > But I can't come up with a better solution, so this RFC patch > does exactly that. It turns off port power for xHC roothub ports > in the hibernate poweroff_late stage, but only if the host isn't set > to wake up the system from S4. In general this looks like the sane strategy. However, what will this do if the port is in an alternate mode or if this is the port the system's battery is to be charged through? Regards Oliver
