Re: [PATCH] USB: serial: Fix read regression in 2.6.31

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> In theory, at least, this should be serialized by the TTY core.  In
> practice it probably isn't, since the core relies so heavily on the
> BKL.  Still, I would prefer to fix the core rather than change
> usb-serial.

tty_mutex addresses some of that but it does still use the BKL which is
ugly

> Locking in the TTY layer is a mess.  Open races with just about
> everything else, and in addition hangup races with close.  Not to
> mention races involving the I/O and line discipline paths or the serial
> attributes (baud rate and so on).  Until this is fixed properly,

baud rate etc is all locked cleanly by the termios lock.  Its one bright
spot that was finished ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux