* Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote: > Ingo Molnar wrote: > >> USB: support for autosuspend in sierra while online > > > > FYI, -tip testing found a build failure with the sierra driver on > > !CONFIG_PM - fixed via the patch below. > > > > Thanks, > > > > Ingo > > > > --------------------> > > From 26f8ed899041199caa9315e057a28d10f81b5b88 Mon Sep 17 00:00:00 2001 > > From: Ingo Molnar <mingo@xxxxxxx> > > Date: Wed, 23 Sep 2009 19:19:47 +0200 > > Subject: [PATCH] USB sierra: Fix build if !CONFIG_PM > > > > This build failure: > > > > drivers/usb/serial/sierra.c: In function 'sierra_suspend': > > drivers/usb/serial/sierra.c:936: error: 'struct usb_device' has no member named 'auto_pm' > > > > Triggers because the ->auto_pm functionality depends on CONFIG_PM. > > > > Signed-off-by: Ingo Molnar <mingo@xxxxxxx> > > Ack. > http://marc.info/?l=linux-usb&m=125305135600816&w=2 > > lossy. :( yeah, indeed. Btw., i think my patch is a bit better as it also includes stop_read_write_urbs() in the #ifdef block - your patch would probably trigger a 'defined but not used' compiler warning. (have not checked though.) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
