Dear Greg, On Do, Mai 12, 2022 at 01:38:36 +0200, Greg Kroah-Hartman wrote: > On Thu, May 12, 2022 at 01:15:27PM +0200, Eugeniu Rosca wrote: > > From: Bhuvanesh Surachari <Bhuvanesh_Surachari@xxxxxxxxxx> [..] > > if (!envp[1]) > > - goto exit; > > + goto exit_path; > > No need to rename this, right? > > > > > - envp[2] = NULL; > > kobject_uevent_env(&hub_dev->kobj, KOBJ_CHANGE, envp); > > > > +exit_path: > > kfree(envp[1]); > > -exit: > > Move this up one line? Thank you for your comments. Much appreciated. Please, find the updated version at: https://lore.kernel.org/linux-usb/1652369834-4480-1-git-send-email-erosca@xxxxxxxxxxxxxx Best regards, Eugeniu
