Re: [PATCH] drivers:Modify the return value to void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Zhou jie <zhoujie@xxxxxxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] drivers:Modify the return value to void
From: Oliver Neukum <oneukum@xxxxxxxx>
Date: Thu, 12 May 2022 11:58:08 +0200
Cc: linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20220512093210.GA6602@localhost.localdomain>
References: <20220512093210.GA6602@localhost.localdomain>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0


On 12.05.22 11:32, Zhou jie wrote:
> drivers:Modify the return value to void

Hi,

technically the patch is obviously correct. Yet, it is not a good idea.
write_mos_reg() can fail and hiding errors is not a good strategy.
You'd better propagate the error.

    Regards
        Oliver

References:
- [PATCH] drivers:Modify the return value to void
  - From: Zhou jie

Prev by Date: [PATCH v3] usb: gadget: uvc: add framebased stream support
Next by Date: Re: [v4 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings
Previous by thread: Re: [PATCH] drivers:Modify the return value to void
Next by thread: [PATCH] usb: hub: Simplify error and success path in port_over_current_notify
Index(es):
- Date
- Thread

[Index of Archives] [Linux Media] [Linux Input] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Old Linux USB Devel Archive]

Powered by Linux