On 02.05.22 05:49, Tetsuo Handa wrote: Hi, there is one open question with this patch I am afraid. > > @@ -533,8 +550,10 @@ static int display_open(struct inode *inode, struct file *file) > > mutex_unlock(&ictx->lock); > > + if (retval && refcount_dec_and_test(&ictx->users)) > + free_imon_context(ictx); > + > When could this ever happen? Either the device is disconnected, then you'll go to 'exit' or the refcount will go back to something >0, won't it? Regards Oliver