On Wed, Apr 27, 2022 at 06:24:26PM +0900, Jung Daehwan wrote: > On Tue, Apr 26, 2022 at 12:21:40PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 26, 2022 at 06:18:48PM +0900, Daehwan Jung wrote: > > > +int xhci_check_trb_in_td_math(struct xhci_hcd *xhci); > > > +void xhci_segment_free(struct xhci_hcd *xhci, struct xhci_segment *seg); > > > +void xhci_link_segments(struct xhci_segment *prev, > > > + struct xhci_segment *next, > > > + enum xhci_ring_type type, bool chain_links); > > > +void xhci_initialize_ring_info(struct xhci_ring *ring, > > > + unsigned int cycle_state); > > > +void xhci_remove_stream_mapping(struct xhci_ring *ring); > > > > Why does your single driver have global functions? That should not be > > needed, right? > > > > And these are odd for a driver's namespace... > > > > Those are exported in 1st patches. it's not good to include here as you said. If you export a function, you also have to add it to a .h file somewhere, otherwise it really is not exported. thanks, greg k-h
