On Wed, Apr 20, 2022 at 12:06:36PM +0300, Heikki Krogerus wrote: > Mon, Apr 18, 2022 at 04:24:25PM +0800, Ren Zhijie kirjoitti: > > Building without CONFIG_POWER_SUPPLY will fail: > > > > drivers/usb/typec/rt1719.o: In function `rt1719_psy_set_property': > > rt1719.c:(.text+0x10a): undefined reference to `power_supply_get_drvdata' > > drivers/usb/typec/rt1719.o: In function `rt1719_psy_get_property': > > rt1719.c:(.text+0x2c8): undefined reference to `power_supply_get_drvdata' > > drivers/usb/typec/rt1719.o: In function `devm_rt1719_psy_register': > > rt1719.c:(.text+0x3e9): undefined reference to `devm_power_supply_register' > > drivers/usb/typec/rt1719.o: In function `rt1719_irq_handler': > > rt1719.c:(.text+0xf9f): undefined reference to `power_supply_changed' > > drivers/usb/typec/rt1719.o: In function `rt1719_update_pwr_opmode.part.9': > > rt1719.c:(.text+0x657): undefined reference to `power_supply_changed' > > drivers/usb/typec/rt1719.o: In function `rt1719_attach': > > rt1719.c:(.text+0x83e): undefined reference to `power_supply_changed' > > > > Add POWER_SUPPLY dependency to Kconfig. > > Thanks. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > > Fixes: 25d29b980912 ("usb: typec: rt1719: Add support for Richtek RT1719") > > Signed-off-by: Ren Zhijie <renzhijie2@xxxxxxxxxx> > > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > Reviewed-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx> > > --- > > drivers/usb/typec/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > > index 8f921213b17d..ba24847fb245 100644 > > --- a/drivers/usb/typec/Kconfig > > +++ b/drivers/usb/typec/Kconfig > > @@ -56,6 +56,7 @@ config TYPEC_RT1719 > > tristate "Richtek RT1719 Sink Only Type-C controller driver" > > depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > > depends on I2C > > + depends on POWER_SUPPLY > > select REGMAP_I2C > > help > > Say Y or M here if your system has Richtek RT1719 sink only > > -- > > 2.17.1 > > -- > heikki