On Tue, 2022-04-19 at 11:05 +0000, cgel.zte@xxxxxxxxx wrote:
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. This change is just to simplify the code, no
> actual functional changes.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
Reviewed-by: Bastien Nocera <hadess@xxxxxxxxxx>
Thanks!
> ---
> drivers/usb/misc/apple-mfi-fastcharge.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c
> b/drivers/usb/misc/apple-mfi-fastcharge.c
> index ac8695195c13..fba102245d8f 100644
> --- a/drivers/usb/misc/apple-mfi-fastcharge.c
> +++ b/drivers/usb/misc/apple-mfi-fastcharge.c
> @@ -119,11 +119,9 @@ static int apple_mfi_fc_set_property(struct
> power_supply *psy,
>
> dev_dbg(&mfi->udev->dev, "prop: %d\n", psp);
>
> - ret = pm_runtime_get_sync(&mfi->udev->dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(&mfi->udev->dev);
> + ret = pm_runtime_resume_and_get(&mfi->udev->dev);
> + if (ret < 0)
> return ret;
> - }
>
> switch (psp) {
> case POWER_SUPPLY_PROP_CHARGE_TYPE:
