On 4/10/22 11:29 PM, Hangyu Hua wrote:
On 2022/4/8 23:04, Shuah Khan wrote:
On 4/7/22 7:59 PM, Hangyu Hua wrote:
Hi Shuah,
I find this by code review. Do i really need to add this to commit log? This look like a little weird.
Great. Good find.
It is important to understand how the problem is found. Please add it
the change log. We usually expect dmesg or such info. that revealed
refcount leak, since this one is found during code review, we would
like to see that information the commit log.
Also please remember to avoid top posting.
I get what you meant now. But i don't know how to get a clear dmesg or any other log. The kernel will not crash because of this. I just used gdb to find that udev->dev->kobj->kref gets bigger and bigger whenever I call stub_probe with busid_priv->status = STUB_BUSID_REMOV.
Thanks for telling me the rules.
There is no need to gather dmesg etc. Just add a note that you found
the problem during code review. Having complete information about why
a change is made will be helpful for future changes to this code and
somebody new trying understand the changes made to this file/routine
and why.
thanks,
-- Shuah
