Re: [PATCH v1 2/2] net: usb: cdc_ether: Add Fibocom MA510 modem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Lars,

On 4/8/22 15:35, Bjørn Mork wrote:
Lars Melin <larsm17@xxxxxxxxx> writes:

Why do you add this modem to the whitelist?

I believe the clue is the

+	.driver_info = (unsigned long)&wwan_info,

to set FLAG_WWAN instead of the default FLAG_ETHER | FLAG_POINTTOPOINT

Bjørn is right that this is the reason. The Fibocom MA510 and L610 are cellular modems, so they require to be labelled as WWAN devices. As such they require to be set up (using AT commands or similar) before the connection can be used. Furthermore, WWAN devices get a different routing metric assigned by the network manager than regular Ethernet devices.

The net interface has the correct cdc_ether attributes so the
cdc_ether driver should bind automagically without any need for the
modem to be in the whitelist.

Yes, this sort of works against the class driver philosophy.  But we've
already started down that road, so...



Bjørn



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux