Hi, Last year Ahmad asked what is the correct order when calling phy_init and phy_power_on. Since then, I didn't see the situation improve much and I am once again toying around with usb phy driver. The following two patches were in my tree for a year... Last year i previously tried to change the call order in the dwc2 driver but this requires the relevent phy to be also compatible with the "new" ordering. The stm32-usbphyc driver wasn't compatible, I am not sure if that is still is the case. For now simply add documentation, hopefully correct, but I am not an expert on actual phy sementics or usage in the kernel. And add warning when the order is not what's expected. Best, --- v2: Updated the documentation syntax for returned value v3: Put the warning msg inside the locked section as suggested by Ahmad Jules Maselbas (3): phy: core: Add documentation of phy operation order phy: core: Update documentation syntax phy: core: Warn when phy_power_on is called before phy_init drivers/phy/phy-core.c | 44 +++++++++++++++++++++++++++++++++++++++--- 1 file changed, 41 insertions(+), 3 deletions(-) -- 2.17.1