Re: [PATCH] USB: serial: Fix read regression in 2.6.31

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Any other suggestions?

For those cases the last set of patches merged added

extern inline int tty_port_users(struct tty_port *port)
{
	return port->count + port->blocked_open;
}

however using that without care (eg without holding the port lock) will
leave races. There is of course no reason the USB layer shouldn't either
keep another flag that indicates what USB needs to know or just adjust
where it sets ASYNCB_INITIALIZED.

However - you need to think hard about what the rules are for the URB
retransmission versus a parallel hangup/close/open sequence. Trying to do
it in the interrupt handler seems rather bogus when the URB could be
cancelled in the close down call ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux